[ovs-dev] [PATCH 1/2] ovn-nbctl: Add NAT commands.

nickcooper-zhangtonghao nic at opencloud.tech
Mon Nov 21 15:56:28 UTC 2016


Hi Guru Shetty
The logical_ip address or network should be SNATed to an external_ip in a gw router, then it's unnecessary that the logical_ip is mapped to 
multiple external IPs. The external_ip should also be DNATed to a logical_ip address, then it's unnecessary that external_ip is mapped to 
multiple logical IPs.

The first condition check the logical ip or external ip according to nat type. If first condition check return true,
we check external ip or logical ip for giving more details about the reason for the error.


Thanks.
Nick

> On Nov 19, 2016, at 1:42 AM, Guru Shetty <guru at ovn.org> wrote:
> 
> Is there any reason why we need the is_snat check in the above 2 conditions? It looks to me that we check the logical_ip and external_ip for all cases. Why is it important what the outer condition or inner condition is?
> 
> Otherwise, this looks good to me.



More information about the dev mailing list