[ovs-dev] [PATCH] datapath-windows: null comparison for icmp and tcp header

Sairam Venugopal vsairam at vmware.com
Tue Nov 29 18:22:41 UTC 2016


Acked-by: Sairam Venugopal <vsairam at vmware.com>


On 11/28/16, 6:11 AM, "Alin Serdean" <aserdean at cloudbasesolutions.com>
wrote:

>This patch checks if the TCP or ICMP header exists before trying to use
>them.
>
>The issue was found using the driver under low resources.
>
>Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
>---
> datapath-windows/ovsext/Conntrack.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/datapath-windows/ovsext/Conntrack.c
>b/datapath-windows/ovsext/Conntrack.c
>index e663c3b..56a7cbc 100644
>--- a/datapath-windows/ovsext/Conntrack.c
>+++ b/datapath-windows/ovsext/Conntrack.c
>@@ -194,7 +194,7 @@ OvsCtEntryCreate(PNET_BUFFER_LIST curNbl,
>             TCPHdr tcpStorage;
>             const TCPHdr *tcp;
>             tcp = OvsGetTcp(curNbl, l4Offset, &tcpStorage);
>-            if (!OvsConntrackValidateTcpPacket(tcp)) {
>+            if (!tcp || !OvsConntrackValidateTcpPacket(tcp)) {
>                 goto invalid;
>             }
> 
>@@ -215,7 +215,7 @@ OvsCtEntryCreate(PNET_BUFFER_LIST curNbl,
>             ICMPHdr storage;
>             const ICMPHdr *icmp;
>             icmp = OvsGetIcmp(curNbl, l4Offset, &storage);
>-            if (!OvsConntrackValidateIcmpPacket(icmp)) {
>+            if (!icmp || !OvsConntrackValidateIcmpPacket(icmp)) {
>                 goto invalid;
>             }
> 
>-- 
>2.10.2.windows.1
>_______________________________________________
>dev mailing list
>dev at openvswitch.org
>https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_
>mailman_listinfo_ovs-2Ddev&d=DgICAg&c=uilaK90D4TOVoH58JNXRgQ&r=Z6vowHUOjP5
>ysP_g372c49Nqc1vEKqHKNBkR5Q5Z7uo&m=-wRL0MTKq-S9BvlASxl9rr16XAVdEV1G13MXuz-
>w4Uc&s=DpjyrkLlyPupeYfaSrHUQUlVt5PzkEdOvOzvNfViLPQ&e= 



More information about the dev mailing list