[ovs-dev] OVS-Hyper-V-Discovery-Agent Design Document

Yin Lin yinlin10 at gmail.com
Tue Nov 29 22:54:38 UTC 2016


Hi Alin,

Thanks for the feedbacks. As regards to your three concerns:

1. I do not like a new daemon either. But as Nithin and Ben pointed out,
there might be a lot of push back if we make ovs-switchd manipulate ovsdb
by adding and deleting ports.
2. The cmd calls can easily be done away by creating a wrapper around
ovs-vsctl.c and compile it with my daemon. The problem was that all
functions in ovs-vsctl.c is static and I'm not too happy with copying
almost 90% of the codes over to a new file. We need to figure out the best
way to share the code. But according to feedback from Nithin, it is not
urgent for now and we can post is as a follow up patch.
3. There is a trade off here. Without .NET it's too much pain to work with
WMI event callbacks and the code is so hard to read and prone to err that
it's hardly maintainable. I don't think it's excessive to require a Windows
server to have basic .NET framework installed, without which not many
Windows apps are even able to launch.

Best regards,
Yin Lin

On Mon, Nov 28, 2016 at 11:18 AM, Alin Serdean <
aserdean at cloudbasesolutions.com> wrote:

> Hi Yin,
>
> Thanks a lot for the patch and the document!
>
> There are a few concerns that I have with this implementation:
> - the need for a new daemon,
> - use of cmd calls to add/delete ports,
> - addition of .NET to compile the binaries.
>
> As previously discussed in the meetings, we could just use 'ovs-vswitchd'
> with an argument i.e. '--integration_bridge=<bridge>' to add the ports.
> We see the port creations in the kernel and we could issue an event to the
> userspace to add ports under that bridge. We could add a new type of
> 'action' or try to reuse the events that are already present in the
> implementation.
> Another advantage to use ovs-vswitchd is that we could talk directly to
> ovsdb. Also, no additional dependency needed.
>
> We could add the argument '--integration_bridge=<bridge>' when creating
> the service via the installer with a nice text to inform the user about
> what it does. Changing the service properties is normal activity for a
> system administrator, so he could easily remove it afterwards.
>
> Thanks,
> Alin.
>
> > -----Original Message-----
> > From: ovs-dev-bounces at openvswitch.org [mailto:ovs-dev-
> > bounces at openvswitch.org] On Behalf Of Yin Lin
> > Sent: Monday, November 21, 2016 10:07 PM
> > To: dev at openvswitch.org
> > Subject: [ovs-dev] OVS-Hyper-V-Discovery-Agent Design Document
> >
> > Hi,
> >
> > Below is a document that describes the design and implementation of VIF
> > discovery agent for Hyper-V that I have been working on. The coding has
> > already been completed and will be sent out for review in a follow up
> patch.
> > The document describes the effort and the choices made. Thanks Sairam
> > Venugopal for the initial review and edit of the document
> >
> >
> >
> > Please have a look, and get in touch for any questions or comments.
> >
> >
> >
> > Thanks!
> >
> > -- Yin
>


More information about the dev mailing list