[ovs-dev] [PATCH] datapath: backport: openvswitch: Fix skb leak in IPv6 reassembly.

Daniele Di Proietto diproiettod at vmware.com
Wed Nov 30 23:30:45 UTC 2016






On 30/11/2016 14:40, "Joe Stringer" <joe at ovn.org> wrote:

>On 30 November 2016 at 10:41, Daniele Di Proietto
><diproiettod at vmware.com> wrote:
>>     commit f92a80a9972175a6a1d36c6c44be47fb0efd020d
>>     Author: Daniele Di Proietto <diproiettod at ovn.org>
>>     Date:   Mon Nov 28 15:43:53 2016 -0800
>>
>>     openvswitch: Fix skb leak in IPv6 reassembly.
>>
>>     If nf_ct_frag6_gather() returns an error other than -EINPROGRESS, it
>>     means that we still have a reference to the skb.  We should free it
>>     before returning from handle_fragments, as stated in the comment above.
>>
>>     Fixes: daaa7d647f81 ("netfilter: ipv6: avoid nf_iterate recursion")
>>     CC: Florian Westphal <fw at strlen.de>
>>     CC: Pravin B Shelar <pshelar at ovn.org>
>>     CC: Joe Stringer <joe at ovn.org>
>>     Signed-off-by: Daniele Di Proietto <diproiettod at ovn.org>
>>     Acked-by: Pravin B Shelar <pshelar at ovn.org>
>>     Signed-off-by: David S. Miller <davem at davemloft.net>
>>
>> VMware-BZ: #1728498
>> Fixes: 2e602ea3dafa("compat: nf_defrag_ipv6: avoid nf_iterate recursion.")
>> Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
>
>Thanks for tracking this down.
>
>Acked-by: Joe Stringer <joe at ovn.org>

Thanks, I pushed this to master and branch-2.6


More information about the dev mailing list