[ovs-dev] [PATCH 1/5] lib/dp-packet: init the mbuf to zero when build with DPDK

Michael Qiu qiudayu at chinac.com
Tue Nov 1 03:11:05 UTC 2016



  2016/10/28 17:25, Kavanagh, Mark B :
>> When building with DPDK, and using xmalloc() to get a new packet,
>> field mbuf of the packet will not be initialized, but it's very important for
>> DPDK port when copying the data to DPDK mbuf, because if ol_flags
>> and other info are random values, DPDK driver may hang.
>>
>> Signed-off-by: Michael Qiu <qiudayu at chinac.com>
>> Signed-off-by: Jijiang Liu <liujijiang at chinac.com>
> Thanks for the patch Michael; one minor nit, but otherwise looks good to me.
>
>> ---
>> lib/dp-packet.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/lib/dp-packet.c b/lib/dp-packet.c
>> index 8e7defc..bf8522e 100644
>> --- a/lib/dp-packet.c
>> +++ b/lib/dp-packet.c
>> @@ -131,6 +131,9 @@ struct dp_packet *
>> dp_packet_new(size_t size)
>> {
>>      struct dp_packet *b = xmalloc(sizeof *b);
>> +    #ifdef DPDK_NETDEV
> Compiler guards should be aligned all the way to the left

Hi, Mark

This should be the display issue, these three lines are all aligned with 
4 whitespaces.

Thanks,
Michael
>
>> +    memset(&(b->mbuf), 0, sizeof(struct rte_mbuf));
>> +    #endif
>>      dp_packet_init(b, size);
>>      return b;
>> }
>> --
>> 1.8.3.1
>

-- 
仇大玉 | Michael
技术经理 | 系统创新产品线

手机:18952051001

电话:021-60478730-2252

邮箱:qiudayu at chinac.com

-------------------------------------------------

华云数据技术服务有限公司

上海市杨浦区伟成路70号企业中心1号楼903-05单元

网址:http://www.chinac.com

       24小时服务电话:400-808-4000



More information about the dev mailing list