[ovs-dev] [patch_v2 1/3] ovn: Skip logical switch "router type" port arp responder install.

Darrell Ball dlu998 at gmail.com
Sat Oct 1 23:34:52 UTC 2016


Do not install any potential logical switch "router type"
port arp responders.  Logical router port arp responders
should be sufficient in this respect.
It seems a little wierd for a logical switch not proxying
for a remote VIF to be responding to arp requests and we
are not functionally using this capability in ovn.

Signed-off-by: Darrell Ball <dlu998 at gmail.com>
---
 ovn/northd/ovn-northd.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
index eeeb41d..17ea90f 100644
--- a/ovn/northd/ovn-northd.c
+++ b/ovn/northd/ovn-northd.c
@@ -2699,11 +2699,11 @@ build_lswitch_flows(struct hmap *datapaths, struct hmap *ports,
         }
 
         /*
-         * Add ARP/ND reply flows if either the
-         *  - port is up or
-         *  - port type is router
+         * Add ARP/ND reply flows if the
+         *  - port is up and
+         *  - port type is not router
          */
-        if (!lsp_is_up(op->nbsp) && strcmp(op->nbsp->type, "router")) {
+        if (!lsp_is_up(op->nbsp) || !strcmp(op->nbsp->type, "router")) {
             continue;
         }
 
-- 
1.9.1




More information about the dev mailing list