[ovs-dev] [PATCH v2] netdev-linux: double tagged packets should use 0x88a8

Ben Pfaff blp at ovn.org
Tue Oct 4 15:48:53 UTC 2016


On Tue, Oct 04, 2016 at 10:14:46AM -0400, Eric Garver wrote:
> We need to check if a packet is double tagged. If so make sure to push
> 0x88a8 instead of 0x8100. Without this a simple port redirect of 802.1ad
> frames means the outer tag gets translated from 0x88a8 to 0x8100 by the
> userspace datapath.
> 
> This only affected kernels that don't use TP_STATUS_VLAN_TPID_VALID,
> which is kernels < 3.14.
> 
> Signed-off-by: Eric Garver <e at erig.me>
> ---
> v2:
>   - move double tag check to after retval length check
>   - variable renames

Thanks, I applied this to master and backported as far as OVS 2.4.



More information about the dev mailing list