[ovs-dev] [PATCH] ovstest: Initialize command mode to RO

Aaron Conole aconole at redhat.com
Tue Oct 4 20:18:10 UTC 2016


When the read-only infrastucture support was added, the test-suite
registration was missed.  This causes tools like valgrind to complain
about uninitialized variable usage.

Fixes: 1f4a7252d9e7 ("Add read-only option to ovs-dpctl and...")
Cc: Ryan Moats <rmoats at us.ibm.com>
Signed-off-by: Aaron Conole <aconole at redhat.com>
---
NOTE: I've set this to RO - not sure if RW would be the right thing here?

 tests/ovstest.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/ovstest.c b/tests/ovstest.c
index 745bd2e..d258232 100644
--- a/tests/ovstest.c
+++ b/tests/ovstest.c
@@ -101,6 +101,7 @@ ovstest_register(const char *test_name, ovs_cmdl_handler f)
     test_cmd.min_args = 0;
     test_cmd.max_args = INT_MAX;
     test_cmd.handler = f;
+    test_cmd.mode = OVS_RO;
 
     add_command(&test_cmd);
 }
-- 
2.7.4




More information about the dev mailing list