[ovs-dev] [PATCH v2] Fix missing system-id in INSTALL.Docker

Hui Kang hkang.sunysb at gmail.com
Wed Oct 5 00:38:19 UTC 2016


I like your version better.
I am ok abandoning this patch. Thanks.

- Hui

On Tue, Oct 4, 2016 at 7:01 PM, Ben Pfaff <blp at ovn.org> wrote:
> On Tue, Oct 04, 2016 at 04:33:02PM -0400, Hui Kang wrote:
>> Signed-off-by: Hui Kang <hkang.sunysb at gmail.com>
>> ---
>>  INSTALL.Docker.md | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/INSTALL.Docker.md b/INSTALL.Docker.md
>> index b62922d..4606354 100644
>> --- a/INSTALL.Docker.md
>> +++ b/INSTALL.Docker.md
>> @@ -83,6 +83,14 @@ ovs-vsctl set Open_vSwitch . external_ids:ovn-remote="tcp:$CENTRAL_IP:6642" \
>>    external_ids:ovn-nb="tcp:$CENTRAL_IP:6641" external_ids:ovn-encap-ip=$LOCAL_IP external_ids:ovn-encap-type="$ENCAP_TYPE"
>>  ```
>>
>> +Note that if Open vSwitch is started manually (without the assistance of system
>> +startup scripts provided by packages like .deb or .rpm), you should provide a
>> +unique identification, $SYSTEM_ID for this host:
>> +
>> +```
>> +ovs-vsctl set Open_vSwitch . external_ids:system-id=$SYSTEM_ID
>> +```
>> +
>>  And finally, start the ovn-controller.  (You need to run the below command
>>  on every boot)
>
> Thanks for working on this.
>
> I'm concerned about this wording, because the system-id should be
> persistent and unique and this isn't specific enough to encourage people
> to do it the right way.
>
> I posted my version, see what you think:
>         https://patchwork.ozlabs.org/patch/678263/



More information about the dev mailing list