[ovs-dev] [PATCH v13 2/2] DSCP marking on packets

Babu Shanmugam bschanmu at redhat.com
Wed Oct 5 08:30:52 UTC 2016


On Wednesday 05 October 2016 12:05 AM, Ben Pfaff wrote:
> On Wed, Sep 07, 2016 at 11:40:12AM +0530,bschanmu at redhat.com  wrote:
>> >From: Babu Shanmugam<bschanmu at redhat.com>
>> >
>> >This patch adds support for marking qos on IP packets based on arbitrary
>> >match criteria for a logical switch.
>> >
>> >Signed-off-by: Babu Shanmugam<bschanmu at redhat.com>
>> >Suggested-by: Mickey Spiegel<mickeys.dev at gmail.com>
>> >Acked-by: Mickey Spiegel<mickeys.dev at gmail.com>
> I spent a little time with this, but I couldn't make the test pass.  The
> first issue seems to be that MFF_LOG_CT_ZONE (in reg13) is
> nondeterministic: sometimes I see 0x1, sometimes 0x2.  That's not a
> problem with this patch, so I folded in the appended incremental, which
> also makes sure that the logical port numbers get assigned in the
> expected order, by adding --wait and sync.  But even with that, I get
> the following failure, so i think that some more work is needed here.
>
> Thanks,
>
> Ben.

Ben, I rebased the patch and applied your changes. I could not see any 
failures in any test case. I have published a v14 which is the rebased 
version with your changes. Kindly try it and let me know if you are 
still seeing failures.

Thank you,
Babu



More information about the dev mailing list