[ovs-dev] [PATCH] netdev: Initialize netdev's features before getting them

Aaron Conole aconole at redhat.com
Wed Oct 12 13:26:14 UTC 2016


Hi Binbin,

Binbin Xu <xu.binbin1 at zte.com.cn> writes:

> When OVS&DPDK is used, DPDK doesn't support features 'advertised',
> 'supported' and 'peer'. If a physical port added to bridge, features
> descirbed above can't be assigned, and the values are random.
>
> Signed-off-by: Binbin Xu <xu.binbin1 at zte.com.cn>
> ---

Thanks for reporting this.  I consider this a bug in dpdk, not
something that requires changing the netdev framework.  A look at other
netdev classes confirms this.

Please re-submit something that fixes DPDK, like the following.  If I
read it correctly, you might also submit an additional patch to cleanup
the interface in lib/netdev-bsd.c (which seems to be 'mismatched').

NOTE patch is *completely* untested, not even compile tested.

---
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 39bf930..6f5ec43 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -1978,13 +1978,15 @@ out:
 static int
 netdev_dpdk_get_features(const struct netdev *netdev,
                          enum netdev_features *current,
-                         enum netdev_features *advertised OVS_UNUSED,
-                         enum netdev_features *supported OVS_UNUSED,
-                         enum netdev_features *peer OVS_UNUSED)
+                         enum netdev_features *advertised,
+                         enum netdev_features *supported,
+                         enum netdev_features *peer)
 {
     struct netdev_dpdk *dev = netdev_dpdk_cast(netdev);
     struct rte_eth_link link;
 
+    *advertised = *peer = *supported = 0;
+
     ovs_mutex_lock(&dev->mutex);
     link = dev->link;
     ovs_mutex_unlock(&dev->mutex);



More information about the dev mailing list