[ovs-dev] [PATCH] tests: Fix double-rebuild of testsuite for "check-valgrind".
blp at ovn.org
Wed Oct 12 17:42:36 UTC 2016
On Tue, Oct 11, 2016 at 04:58:26PM -0700, Andy Zhou wrote:
> On Wed, Oct 5, 2016 at 6:28 PM, Ben Pfaff <blp at ovn.org> wrote:
> > When I ran "make check-valgrind -j10" and the testsuite needed to be
> > rebuilt, two copies of it were rebuilt in parallel and sometimes they
> > raced with each other. I don't have the full story on exactly why this
> > happened, but this commit, which eliminates redundant dependencies from
> > check-* targets, fixes the problem for me. The dependencies are redundant
> > because these targets depend on "all", which also depends on them.
> > Signed-off-by: Ben Pfaff <blp at ovn.org>
> I was not clear to me either why the race happened, but the change looks
> good to me.
> Acked-by: Andy Zhou <azhou at ovn.org>
> There are two additional targets that have the similar pattern, wonder if
> we should change them as well...
You're right. I made those changes too.
My confidence is somewhat shaky on this, but it's easy enough to revert
if we missed something, so I applied this to master.
More information about the dev