[ovs-dev] [PATCH] dpif-netdev: Fix crash in dpif_netdev_execute().

Daniele Di Proietto diproiettod at vmware.com
Thu Oct 13 00:31:01 UTC 2016






On 12/10/2016 12:37, "Ben Pfaff" <blp at ovn.org> wrote:

>On Tue, Oct 04, 2016 at 04:25:35PM -0700, Daniele Di Proietto wrote:
>> dp_netdev_get_pmd() is allowed to return NULL (even if we call it with
>> NON_PMD_CORE_ID) for different reasons:
>> 
>> * Since we use RCU to protect pmd threads, it is possible that
>>   ovs_refcount_try_ref_rcu() has failed.
>> * During reconfiguration we destroy every thread.
>
>I'd recommend making the comment on dp_netdev_get_pmd() clearer, by
>mentioning that it can always return NULL, even with NON_PMD_CORE_ID as
>an argument.

Good point, done

>
>Acked-by: Ben Pfaff <blp at ovn.org>

Thanks, I applied this to master and branch-2.{6,5,4}


More information about the dev mailing list