[ovs-dev] [PATCH] dpdk: Fix DPDK pdump compilation
Daniele Di Proietto
diproiettod at ovn.org
Thu Oct 13 18:10:25 UTC 2016
2016-10-13 10:27 GMT-07:00 Ciara Loftus <ciara.loftus at intel.com>:
> The rte_pdump header file was not included in the file that requires it.
> Fix this.
>
> Fixes: 01961bbdd34a ("dpdk: New module with some code from netdev-dpdk.")
> Signed-off-by: Ciara Loftus <ciara.loftus at intel.com>
>
Oops, thanks for the fix!
I was able to reproduce the build failure only by setting in DPDK
CONFIG_RTE_LIBRTE_PMD_PCAP=y.
I had to add <rte_mempool.h> before <rte_pdump.h> as Aurojit was suggesting.
With that addition I applied this to master.
Thanks,
Daniele
> ---
> lib/dpdk.c | 4 ++++
> lib/netdev-dpdk.c | 3 ---
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/lib/dpdk.c b/lib/dpdk.c
> index caea0f4..c2182a7 100644
> --- a/lib/dpdk.c
> +++ b/lib/dpdk.c
> @@ -22,8 +22,12 @@
> #include <getopt.h>
>
> #include <rte_memzone.h>
> +#ifdef DPDK_PDUMP
> +#include <rte_pdump.h>
> +#endif
>
> #include "dirs.h"
> +#include "fatal-signal.h"
> #include "netdev-dpdk.h"
> #include "openvswitch/dynamic-string.h"
> #include "openvswitch/vlog.h"
> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
> index ab8c34f..7c1523e 100644
> --- a/lib/netdev-dpdk.c
> +++ b/lib/netdev-dpdk.c
> @@ -31,9 +31,6 @@
> #include <rte_malloc.h>
> #include <rte_mbuf.h>
> #include <rte_meter.h>
> -#ifdef DPDK_PDUMP
> -#include <rte_pdump.h>
> -#endif
> #include <rte_virtio_net.h>
>
> #include "dirs.h"
> --
> 2.4.3
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
More information about the dev
mailing list