[ovs-dev] [PATCH v2 07/12] dpif-netdev: Cache align netdev_flow_keys.

Daniele Di Proietto diproiettod at ovn.org
Fri Oct 14 02:13:09 UTC 2016


Acked-by: Daniele Di Proietto <diproiettod at vmware.com>

2016-10-13 2:58 GMT-07:00 Bhanuprakash Bodireddy <
bhanuprakash.bodireddy at intel.com>:

> Aligning the 'keys' array seems to have positive performance impact.
>
> Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodireddy at intel.com>
> Co-authored-by: Antonio Fischetti <antonio.fischetti at intel.com>
> ---
>  lib/dpif-netdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
> index 84aa570..93ea49d 100644
> --- a/lib/dpif-netdev.c
> +++ b/lib/dpif-netdev.c
> @@ -4166,7 +4166,7 @@ dp_netdev_input__(struct dp_netdev_pmd_thread *pmd,
>      /* Sparse or MSVC doesn't like variable length array. */
>      enum { PKT_ARRAY_SIZE = NETDEV_MAX_BURST };
>  #endif
> -    struct netdev_flow_key keys[PKT_ARRAY_SIZE];
> +    struct netdev_flow_key keys[PKT_ARRAY_SIZE]
> OVS_ALIGNED_VAR(CACHE_LINE_SIZE);
>      struct packet_batch_per_flow batches[PKT_ARRAY_SIZE];
>      long long now = time_msec();
>      size_t newcnt, n_batches, i;
> --
> 2.4.11
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>



More information about the dev mailing list