[ovs-dev] [PATCH v2 5/7] checkpatch: Fix signoff error

Aaron Conole aconole at bytheb.org
Fri Oct 21 18:49:07 UTC 2016


When no 'Signed-off-by' tags are found, the output will look like:

    E: No signatures found.
    E: Too many signoffs; are you missing Co-authored-by lines?
    Warnings: 0, Errors: 2

However, there should really only be one error reported in this case.

Signed-off-by: Aaron Conole <aconole at bytheb.org>
---
 utilities/checkpatch.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
index 985641a..d21574c 100755
--- a/utilities/checkpatch.py
+++ b/utilities/checkpatch.py
@@ -188,7 +188,7 @@ def ovs_checkpatch_parse(text):
                 if not skip_signoff_check:
                     if len(signatures) == 0:
                         print_error("No signatures found.")
-                    if len(signatures) != 1 + len(co_authors):
+                    elif len(signatures) != 1 + len(co_authors):
                         print_error("Too many signoffs; "
                                     "are you missing Co-authored-by lines?")
                     if not set(co_authors) <= set(signatures):
-- 
2.7.4




More information about the dev mailing list