[ovs-dev] [PATCH 1/2] tests: Fix order confusion in "ovn -- 2 HVs, 4 lports/HV, localnet ports".

Ben Pfaff blp at ovn.org
Sun Oct 23 17:50:35 UTC 2016


The order of src and dst was swapped both in assignment and reference,
which meant that the result worked OK but was really confusing to try to
extend or modify.

Signed-off-by: Ben Pfaff <blp at ovn.org>
---
 tests/ovn.at | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/ovn.at b/tests/ovn.at
index da0291f..1d782a3 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -1592,8 +1592,8 @@ for i in 1 2; do
     done
 done
 test_packet() {
-    local inport=$1 src=$2 dst=$3 eth=$4; shift; shift; shift; shift
-    local packet=${src}${dst}${eth}
+    local inport=$1 dst=$2 src=$3 eth=$4; shift; shift; shift; shift
+    local packet=${dst}${src}${eth}
     hv=`vif_to_hv $inport`
     vif=vif$inport
     as $hv ovs-appctl netdev-dummy/receive $vif $packet
-- 
2.1.3




More information about the dev mailing list