[ovs-dev] [PATCH 3/5 v2] datapath-windows: clean code in gre
Alin Serdean
aserdean at cloudbasesolutions.com
Thu Oct 27 18:55:36 UTC 2016
The purpose of this patch is to make the code more readable and
fix a static analyzer warning.
Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
---
datapath-windows/ovsext/Gre.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/datapath-windows/ovsext/Gre.c b/datapath-windows/ovsext/Gre.c
index 1976b08..7d6c0a2 100644
--- a/datapath-windows/ovsext/Gre.c
+++ b/datapath-windows/ovsext/Gre.c
@@ -215,10 +215,10 @@ OvsDoEncapGre(POVS_VPORT_ENTRY vport,
/* L2 header */
ethHdr = (EthHdr *)bufferStart;
- ASSERT(((PCHAR)&fwdInfo->dstMacAddr + sizeof fwdInfo->dstMacAddr) ==
- (PCHAR)&fwdInfo->srcMacAddr);
NdisMoveMemory(ethHdr->Destination, fwdInfo->dstMacAddr,
- sizeof ethHdr->Destination + sizeof ethHdr->Source);
+ sizeof ethHdr->Destination);
+ NdisMoveMemory(ethHdr->Source, fwdInfo->srcMacAddr,
+ sizeof ethHdr->Source);
ethHdr->Type = htons(ETH_TYPE_IPV4);
#if DBG
counterHeadRoom -= sizeof *ethHdr;
--
2.9.2.windows.1
More information about the dev
mailing list