[ovs-dev] [PATCH] learn: learn_spec fixes.

Jarno Rajahalme jarno at ovn.org
Thu Sep 1 20:32:27 UTC 2016


> On Sep 1, 2016, at 1:18 PM, Ben Pfaff <blp at ovn.org> wrote:
> 
> On Thu, Sep 01, 2016 at 01:10:37PM -0700, Jarno Rajahalme wrote:
>> Avoid using nested zero-sized arrays to allow compilation with MSVC.
>> Also, make sure the immediate data is accessed only if it exists, and
>> that the size is always calculated from struct learn_spec field
>> 'n_bits'.
>> 
>> Reported-by: Alin Serdean <aserdean at cloudbasesolutions.com>
>> Signed-off-by: Jarno Rajahalme <jarno at ovn.org>
> 
> It looks good to me but the title could be more specific.  "learn: Avoid
> nested zero-sized arrays to fix build with MSVC." or some such.
> 
> Acked-by: Ben Pfaff <blp at ovn.org>

Thanks for the prompt review. Pushed to master and branch-2.6 with the new title and Fixes: header.

  Jarno




More information about the dev mailing list