[ovs-dev] [PATCH 3/3] rhel: add option to run kernel datapath test when building rpms

Joe Stringer joe at ovn.org
Thu Sep 1 20:51:19 UTC 2016


On 1 September 2016 at 13:14, Lance Richardson <lrichard at redhat.com> wrote:
> Add ability to execute kernel datapath tests when building rpms.
> These tests are disabled by default, and can optionally be run
> by providing "--with check_datapath_kernel" on the rpmbuild command
> line.  This is intended to facilitate automated testing, and
> should not be used in production environments (it is generally not
> recommended to run rpmbuild as root).
>
> Suggested-by: Flavio Leitner <fbl at sysclose.org>
> Signed-off-by: Lance Richardson <lrichard at redhat.com>

Neat.

So, when you run 'check-kernel' it will just use whatever module is
currently installed. I guess that if you want to see the behaviour
just with the upstream openvswitch module, you could run the rpmbuild
for the package with the option as you specified in the commit
message, without first installing a kmod or dkms package.

If you're building a DKMS package as well, and you wanted to test the
dkms module, then you'd have to install that package first, then do
rpmbuild.

It probably wouldn't hurt to briefly mention this fact somewhere
(either in the spec or the commit message), since the tests are used
with the 'openvswitch' package, not the module packages.

This patch looks fine to me, although I wouldn't mind if Flavio took a
quick look before it is merged since he suggested it.



More information about the dev mailing list