[ovs-dev] [PATCH 3/3] rhel: add option to run kernel datapath test when building rpms

[Lance Richardson]

> From: "Joe Stringer" <joe at ovn.org>
> To: "Lance Richardson" <lrichard at redhat.com>
> Cc: "ovs dev" <dev at openvswitch.org>
> Sent: Thursday, September 1, 2016 4:51:19 PM
> Subject: Re: [ovs-dev] [PATCH 3/3] rhel: add option to run kernel datapath test when building rpms
> 
> On 1 September 2016 at 13:14, Lance Richardson <lrichard at redhat.com> wrote:
> > Add ability to execute kernel datapath tests when building rpms.
> > These tests are disabled by default, and can optionally be run
> > by providing "--with check_datapath_kernel" on the rpmbuild command
> > line.  This is intended to facilitate automated testing, and
> > should not be used in production environments (it is generally not
> > recommended to run rpmbuild as root).
> >
> > Suggested-by: Flavio Leitner <fbl at sysclose.org>
> > Signed-off-by: Lance Richardson <lrichard at redhat.com>
> 
> Neat.
> 
> So, when you run 'check-kernel' it will just use whatever module is
> currently installed. I guess that if you want to see the behaviour
> just with the upstream openvswitch module, you could run the rpmbuild
> for the package with the option as you specified in the commit
> message, without first installing a kmod or dkms package.

Right, at the moment I'm mainly looking to run this against the upstream
in-tree kernel module and a particular distro's kernel module.

> 
> If you're building a DKMS package as well, and you wanted to test the
> dkms module, then you'd have to install that package first, then do
> rpmbuild.
> 
Good point, I hadn't really thought much about that use case other than
having the vague untested notion that it should work.

> It probably wouldn't hurt to briefly mention this fact somewhere
> (either in the spec or the commit message), since the tests are used
> with the 'openvswitch' package, not the module packages.
> 
I'll try that out and include added documentation with a v2.

> This patch looks fine to me, although I wouldn't mind if Flavio took a
> quick look before it is merged since he suggested it.
> 
Sounds good, thanks for reviewing!

   Lance