[ovs-dev] [PATCH] ovn: fix ovn-northd leaks in build_acl

Ramu Ramamurthy ramu.ramamurthy at gmail.com
Fri Sep 2 00:12:03 UTC 2016


Hi Russell, I updated the patch with a Signed-off-by, but it landed
here as new on patchworks,
https://patchwork.ozlabs.org/patch/665079/
instead of updating the original here:
https://patchwork.ozlabs.org/patch/661079/

On Thu, Sep 1, 2016 at 4:50 PM, Russell Bryant <russell at ovn.org> wrote:
>
> On Fri, Aug 19, 2016 at 9:06 PM, Ramu Ramamurthy <ramu.ramamurthy at gmail.com>
> wrote:
>>
>> From: Ramu Ramamurthy <ramu.ramamurthy at us.ibm.com>
>>
>> The following leaks are due to missing ds_destroy in a few
>> places in build_acl.
>>
>> 5,850 bytes in 50 blocks are definitely lost in loss record 93 of 93
>>    at 0x4C29BFD: malloc (in
>> /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
>>    by 0x4C2BACB: realloc (in
>> /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
>>    by 0x449507: xrealloc (util.c:123)
>>    by 0x42CC73: ds_reserve (dynamic-string.c:63)
>>    by 0x42D08F: ds_put_format_valist (dynamic-string.c:161)
>>    by 0x42D176: ds_put_format (dynamic-string.c:142)
>>    by 0x40D380: build_acls (ovn-northd.c:2320)
>>    by 0x40D380: build_lswitch_flows.constprop.36 (ovn-northd.c:2472)
>>    by 0x4072D9: build_lflows (ovn-northd.c:3845)
>>    by 0x4072D9: ovnnb_db_run (ovn-northd.c:3971)
>>    by 0x4072D9: main (ovn-northd.c:4375)
>>
>> 9,360 bytes in 72 blocks are definitely lost in loss record 93 of 93
>>    at 0x4C29BFD: malloc (in
>> /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
>>    by 0x4C2BACB: realloc (in
>> /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
>>    by 0x449507: xrealloc (util.c:123)
>>    by 0x42CC73: ds_reserve (dynamic-string.c:63)
>>    by 0x42D08F: ds_put_format_valist (dynamic-string.c:161)
>>    by 0x42D176: ds_put_format (dynamic-string.c:142)
>>    by 0x40D505: build_acls (ovn-northd.c:2346)
>>    by 0x40D505: build_lswitch_flows.constprop.36 (ovn-northd.c:2472)
>>    by 0x4072D9: build_lflows (ovn-northd.c:3845)
>>    by 0x4072D9: ovnnb_db_run (ovn-northd.c:3971)
>>    by 0x4072D9: main (ovn-northd.c:4375)
>> ---
>>  ovn/northd/ovn-northd.c | 2 ++
>>  1 file changed, 2 insertions(+)
>
>
> I was about to apply this, but it's missing your Signed-off-by.  Can you
> please re-submit with Signed-off-by included?
>
> Thanks,
>
> --
> Russell Bryant



More information about the dev mailing list