[ovs-dev] [PATCH] ovn-controller: Fix match crieria for dynamic mac binding flows

[Chandra S Vejendla]

match struct is not initialized before adding flows for each entry in
mac_bindings table. This results in incorrect match criteria.

Signed-off-by: Chandra Sekhar Vejendla <csvejend at us.ibm.com>
Signed-off-by: Ryan Moats <rmoats at us.ibm.com>
Co-authored-by: Ryan Moats <rmoats at us.ibm.com>
---
 ovn/controller/lflow.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ovn/controller/lflow.c b/ovn/controller/lflow.c
index efac5b3..fa639ae 100644
--- a/ovn/controller/lflow.c
+++ b/ovn/controller/lflow.c
@@ -399,12 +399,12 @@ add_neighbor_flows(struct controller_ctx *ctx,
                    struct hmap *flow_table)
 {
     struct ofpbuf ofpacts;
-    struct match match;
-    match_init_catchall(&match);
     ofpbuf_init(&ofpacts, 0);
 
     const struct sbrec_mac_binding *b;
     SBREC_MAC_BINDING_FOR_EACH (b, ctx->ovnsb_idl) {
+        struct match match;
+        match_init_catchall(&match);
         consider_neighbor_flow(lports, b, &ofpacts, &match, flow_table);
     }
 
-- 
2.8.1