[ovs-dev] [PATCH v2 2/8] lib: rename ovs_nd_opt to ovs_nd_lla_opt
Zongkai LI
zealokii at gmail.com
Sat Sep 3 05:08:57 UTC 2016
Since ovs_nd_mtu_opt and ovs_nd_prefix_opt is introducted, rename
ovs_nd_opt to ovs_nd_lla_opt to specify it's Source/Target Link-layer
Address Option.
v1 -> v2
rebased, separete ovs_nd_opt rename to this patch.
---
lib/flow.c | 26 ++++++++++-----------
lib/odp-execute.c | 20 ++++++++--------
lib/packets.c | 68 +++++++++++++++++++++++++++----------------------------
lib/packets.h | 17 +++++++-------
4 files changed, 65 insertions(+), 66 deletions(-)
diff --git a/lib/flow.c b/lib/flow.c
index ba4f8c7..b442965 100644
--- a/lib/flow.c
+++ b/lib/flow.c
@@ -400,8 +400,8 @@ parse_icmpv6(const void **datap, size_t *sizep, const struct icmp6_hdr *icmp,
while (*sizep >= 8) {
/* The minimum size of an option is 8 bytes, which also is
* the size of Ethernet link-layer options. */
- const struct ovs_nd_opt *nd_opt = *datap;
- int opt_len = nd_opt->nd_opt_len * ND_OPT_LEN;
+ const struct ovs_nd_lla_opt *nd_opt = *datap;
+ int opt_len = nd_opt->len * ND_LLA_OPT_LEN;
if (!opt_len || opt_len > *sizep) {
return;
@@ -410,17 +410,17 @@ parse_icmpv6(const void **datap, size_t *sizep, const struct icmp6_hdr *icmp,
/* Store the link layer address if the appropriate option is
* provided. It is considered an error if the same link
* layer option is specified twice. */
- if (nd_opt->nd_opt_type == ND_OPT_SOURCE_LINKADDR
+ if (nd_opt->type == ND_OPT_SOURCE_LINKADDR
&& opt_len == 8) {
if (OVS_LIKELY(eth_addr_is_zero(arp_buf[0]))) {
- arp_buf[0] = nd_opt->nd_opt_mac;
+ arp_buf[0] = nd_opt->mac;
} else {
goto invalid;
}
- } else if (nd_opt->nd_opt_type == ND_OPT_TARGET_LINKADDR
+ } else if (nd_opt->type == ND_OPT_TARGET_LINKADDR
&& opt_len == 8) {
if (OVS_LIKELY(eth_addr_is_zero(arp_buf[1]))) {
- arp_buf[1] = nd_opt->nd_opt_mac;
+ arp_buf[1] = nd_opt->mac;
} else {
goto invalid;
}
@@ -2273,7 +2273,7 @@ flow_compose_l4(struct dp_packet *p, const struct flow *flow)
(icmp->icmp6_type == ND_NEIGHBOR_SOLICIT ||
icmp->icmp6_type == ND_NEIGHBOR_ADVERT)) {
struct in6_addr *nd_target;
- struct ovs_nd_opt *nd_opt;
+ struct ovs_nd_lla_opt *nd_opt;
l4_len += sizeof *nd_target;
nd_target = dp_packet_put_zeros(p, sizeof *nd_target);
@@ -2282,16 +2282,16 @@ flow_compose_l4(struct dp_packet *p, const struct flow *flow)
if (!eth_addr_is_zero(flow->arp_sha)) {
l4_len += 8;
nd_opt = dp_packet_put_zeros(p, 8);
- nd_opt->nd_opt_len = 1;
- nd_opt->nd_opt_type = ND_OPT_SOURCE_LINKADDR;
- nd_opt->nd_opt_mac = flow->arp_sha;
+ nd_opt->len = 1;
+ nd_opt->type = ND_OPT_SOURCE_LINKADDR;
+ nd_opt->mac = flow->arp_sha;
}
if (!eth_addr_is_zero(flow->arp_tha)) {
l4_len += 8;
nd_opt = dp_packet_put_zeros(p, 8);
- nd_opt->nd_opt_len = 1;
- nd_opt->nd_opt_type = ND_OPT_TARGET_LINKADDR;
- nd_opt->nd_opt_mac = flow->arp_tha;
+ nd_opt->len = 1;
+ nd_opt->type = ND_OPT_TARGET_LINKADDR;
+ nd_opt->mac = flow->arp_tha;
}
}
}
diff --git a/lib/odp-execute.c b/lib/odp-execute.c
index 5a43904..8156ba9 100644
--- a/lib/odp-execute.c
+++ b/lib/odp-execute.c
@@ -185,7 +185,7 @@ odp_set_nd(struct dp_packet *packet, const struct ovs_key_nd *key,
const struct ovs_key_nd *mask)
{
const struct ovs_nd_msg *ns = dp_packet_l4(packet);
- const struct ovs_nd_opt *nd_opt = dp_packet_get_nd_payload(packet);
+ const struct ovs_nd_lla_opt *nd_opt = dp_packet_get_nd_payload(packet);
if (OVS_LIKELY(ns && nd_opt)) {
int bytes_remain = dp_packet_l4_size(packet) - sizeof(*ns);
@@ -193,25 +193,25 @@ odp_set_nd(struct dp_packet *packet, const struct ovs_key_nd *key,
struct eth_addr sll_buf = eth_addr_zero;
struct eth_addr tll_buf = eth_addr_zero;
- while (bytes_remain >= ND_OPT_LEN && nd_opt->nd_opt_len != 0) {
- if (nd_opt->nd_opt_type == ND_OPT_SOURCE_LINKADDR
- && nd_opt->nd_opt_len == 1) {
- sll_buf = nd_opt->nd_opt_mac;
+ while (bytes_remain >= ND_LLA_OPT_LEN && nd_opt->len != 0) {
+ if (nd_opt->type == ND_OPT_SOURCE_LINKADDR
+ && nd_opt->len == 1) {
+ sll_buf = nd_opt->mac;
ether_addr_copy_masked(&sll_buf, key->nd_sll, mask->nd_sll);
/* A packet can only contain one SLL or TLL option */
break;
- } else if (nd_opt->nd_opt_type == ND_OPT_TARGET_LINKADDR
- && nd_opt->nd_opt_len == 1) {
- tll_buf = nd_opt->nd_opt_mac;
+ } else if (nd_opt->type == ND_OPT_TARGET_LINKADDR
+ && nd_opt->len == 1) {
+ tll_buf = nd_opt->mac;
ether_addr_copy_masked(&tll_buf, key->nd_tll, mask->nd_tll);
/* A packet can only contain one SLL or TLL option */
break;
}
- nd_opt += nd_opt->nd_opt_len;
- bytes_remain -= nd_opt->nd_opt_len * ND_OPT_LEN;
+ nd_opt += nd_opt->len;
+ bytes_remain -= nd_opt->len * ND_LLA_OPT_LEN;
}
packet_set_nd(packet,
diff --git a/lib/packets.c b/lib/packets.c
index 0bfd8e0..9d5639d 100644
--- a/lib/packets.c
+++ b/lib/packets.c
@@ -1143,7 +1143,7 @@ packet_set_nd(struct dp_packet *packet, const ovs_be32 target[4],
const struct eth_addr sll, const struct eth_addr tll)
{
struct ovs_nd_msg *ns;
- struct ovs_nd_opt *nd_opt;
+ struct ovs_nd_lla_opt *nd_opt;
int bytes_remain = dp_packet_l4_size(packet);
if (OVS_UNLIKELY(bytes_remain < sizeof(*ns))) {
@@ -1160,33 +1160,33 @@ packet_set_nd(struct dp_packet *packet, const ovs_be32 target[4],
target, true);
}
- while (bytes_remain >= ND_OPT_LEN && nd_opt->nd_opt_len != 0) {
- if (nd_opt->nd_opt_type == ND_OPT_SOURCE_LINKADDR
- && nd_opt->nd_opt_len == 1) {
- if (!eth_addr_equals(nd_opt->nd_opt_mac, sll)) {
+ while (bytes_remain >= ND_LLA_OPT_LEN && nd_opt->len != 0) {
+ if (nd_opt->type == ND_OPT_SOURCE_LINKADDR
+ && nd_opt->len == 1) {
+ if (!eth_addr_equals(nd_opt->mac, sll)) {
ovs_be16 *csum = &(ns->icmph.icmp6_cksum);
- *csum = recalc_csum48(*csum, nd_opt->nd_opt_mac, sll);
- nd_opt->nd_opt_mac = sll;
+ *csum = recalc_csum48(*csum, nd_opt->mac, sll);
+ nd_opt->mac = sll;
}
/* A packet can only contain one SLL or TLL option */
break;
- } else if (nd_opt->nd_opt_type == ND_OPT_TARGET_LINKADDR
- && nd_opt->nd_opt_len == 1) {
- if (!eth_addr_equals(nd_opt->nd_opt_mac, tll)) {
+ } else if (nd_opt->type == ND_OPT_TARGET_LINKADDR
+ && nd_opt->len == 1) {
+ if (!eth_addr_equals(nd_opt->mac, tll)) {
ovs_be16 *csum = &(ns->icmph.icmp6_cksum);
- *csum = recalc_csum48(*csum, nd_opt->nd_opt_mac, tll);
- nd_opt->nd_opt_mac = tll;
+ *csum = recalc_csum48(*csum, nd_opt->mac, tll);
+ nd_opt->mac = tll;
}
/* A packet can only contain one SLL or TLL option */
break;
}
- nd_opt += nd_opt->nd_opt_len;
- bytes_remain -= nd_opt->nd_opt_len * ND_OPT_LEN;
+ nd_opt += nd_opt->len;
+ bytes_remain -= nd_opt->len * ND_LLA_OPT_LEN;
}
}
@@ -1357,7 +1357,7 @@ compose_nd_ns(struct dp_packet *b, const struct eth_addr eth_src,
struct in6_addr sn_addr;
struct eth_addr eth_dst;
struct ovs_nd_msg *ns;
- struct ovs_nd_opt *nd_opt;
+ struct ovs_nd_lla_opt *nd_opt;
uint32_t icmp_csum;
in6_addr_solicited_node(&sn_addr, ipv6_dst);
@@ -1365,15 +1365,15 @@ compose_nd_ns(struct dp_packet *b, const struct eth_addr eth_src,
eth_compose(b, eth_dst, eth_src, ETH_TYPE_IPV6, IPV6_HEADER_LEN);
ns = compose_ipv6(b, IPPROTO_ICMPV6, ipv6_src, &sn_addr,
- 0, 0, 255, ND_MSG_LEN + ND_OPT_LEN);
+ 0, 0, 255, ND_MSG_LEN + ND_LLA_OPT_LEN);
ns->icmph.icmp6_type = ND_NEIGHBOR_SOLICIT;
ns->icmph.icmp6_code = 0;
put_16aligned_be32(&ns->rso_flags, htonl(0));
nd_opt = &ns->options[0];
- nd_opt->nd_opt_type = ND_OPT_SOURCE_LINKADDR;
- nd_opt->nd_opt_len = 1;
+ nd_opt->type = ND_OPT_SOURCE_LINKADDR;
+ nd_opt->len = 1;
/* Copy target address to temp buffer to prevent misaligned access. */
ovs_be32 tbuf[4];
@@ -1382,8 +1382,8 @@ compose_nd_ns(struct dp_packet *b, const struct eth_addr eth_src,
ns->icmph.icmp6_cksum = 0;
icmp_csum = packet_csum_pseudoheader6(dp_packet_l3(b));
- ns->icmph.icmp6_cksum = csum_finish(csum_continue(icmp_csum, ns,
- ND_MSG_LEN + ND_OPT_LEN));
+ ns->icmph.icmp6_cksum = csum_finish(
+ csum_continue(icmp_csum, ns, ND_MSG_LEN + ND_LLA_OPT_LEN));
}
/* Compose an IPv6 Neighbor Discovery Neighbor Advertisement message. */
@@ -1394,20 +1394,20 @@ compose_nd_na(struct dp_packet *b,
ovs_be32 rso_flags)
{
struct ovs_nd_msg *na;
- struct ovs_nd_opt *nd_opt;
+ struct ovs_nd_lla_opt *nd_opt;
uint32_t icmp_csum;
eth_compose(b, eth_dst, eth_src, ETH_TYPE_IPV6, IPV6_HEADER_LEN);
na = compose_ipv6(b, IPPROTO_ICMPV6, ipv6_src, ipv6_dst,
- 0, 0, 255, ND_MSG_LEN + ND_OPT_LEN);
+ 0, 0, 255, ND_MSG_LEN + ND_LLA_OPT_LEN);
na->icmph.icmp6_type = ND_NEIGHBOR_ADVERT;
na->icmph.icmp6_code = 0;
put_16aligned_be32(&na->rso_flags, rso_flags);
nd_opt = &na->options[0];
- nd_opt->nd_opt_type = ND_OPT_TARGET_LINKADDR;
- nd_opt->nd_opt_len = 1;
+ nd_opt->type = ND_OPT_TARGET_LINKADDR;
+ nd_opt->len = 1;
/* Copy target address to temp buffer to prevent misaligned access. */
ovs_be32 tbuf[4];
@@ -1416,8 +1416,8 @@ compose_nd_na(struct dp_packet *b,
na->icmph.icmp6_cksum = 0;
icmp_csum = packet_csum_pseudoheader6(dp_packet_l3(b));
- na->icmph.icmp6_cksum = csum_finish(csum_continue(icmp_csum, na,
- ND_MSG_LEN + ND_OPT_LEN));
+ na->icmph.icmp6_cksum = csum_finish(csum_continue(
+ icmp_csum, na, ND_MSG_LEN + ND_LLA_OPT_LEN));
}
/* Compose an IPv6 Neighbor Discovery Router Advertisement message without
@@ -1516,23 +1516,23 @@ packet_put_ra_sll_opt(struct dp_packet *b, const struct eth_addr lla)
{
size_t prev_l4_size = dp_packet_l4_size(b);
struct ip6_hdr *nh = dp_packet_l3(b);
- nh->ip6_plen = htons(prev_l4_size + ND_OPT_LEN);
+ nh->ip6_plen = htons(prev_l4_size + ND_LLA_OPT_LEN);
struct ovs_ra_msg *ra = dp_packet_l4(b);
- struct ovs_nd_opt *lla_opt;
+ struct ovs_nd_lla_opt *lla_opt;
uint32_t icmp_csum;
- lla_opt = dp_packet_put_uninit(b, sizeof(struct ovs_nd_opt));
- lla_opt->nd_opt_type = ND_OPT_SOURCE_LINKADDR;
- lla_opt->nd_opt_len = 1;
+ lla_opt = dp_packet_put_uninit(b, sizeof(struct ovs_nd_lla_opt));
+ lla_opt->type = ND_OPT_SOURCE_LINKADDR;
+ lla_opt->len = 1;
ovs_be16 *csum = &(ra->icmph.icmp6_cksum);
- *csum = recalc_csum48(*csum, lla_opt->nd_opt_mac, lla);
- lla_opt->nd_opt_mac = lla;
+ *csum = recalc_csum48(*csum, lla_opt->mac, lla);
+ lla_opt->mac = lla;
ra->icmph.icmp6_cksum = 0;
icmp_csum = packet_csum_pseudoheader6(dp_packet_l3(b));
ra->icmph.icmp6_cksum = csum_finish(csum_continue(
- icmp_csum, ra, prev_l4_size + ND_OPT_LEN));
+ icmp_csum, ra, prev_l4_size + ND_LLA_OPT_LEN));
}
uint32_t
diff --git a/lib/packets.h b/lib/packets.h
index d0e1195..656cb61 100644
--- a/lib/packets.h
+++ b/lib/packets.h
@@ -831,15 +831,14 @@ BUILD_ASSERT_DECL(ICMP6_HEADER_LEN == sizeof(struct icmp6_header));
uint32_t packet_csum_pseudoheader6(const struct ovs_16aligned_ip6_hdr *);
-/* Neighbor Discovery option field.
- * ND options are always a multiple of 8 bytes in size. */
-#define ND_OPT_LEN 8
-struct ovs_nd_opt {
- uint8_t nd_opt_type; /* Values defined in icmp6.h */
- uint8_t nd_opt_len; /* in units of 8 octets (the size of this struct) */
- struct eth_addr nd_opt_mac; /* Ethernet address in the case of SLL or TLL options */
+/* Neighbor Discovery option: Source/Target Link-layer Address. */
+#define ND_LLA_OPT_LEN 8
+struct ovs_nd_lla_opt {
+ uint8_t type; /* Values defined in icmp6.h */
+ uint8_t len; /* in units of 8 octets (the size of this struct) */
+ struct eth_addr mac; /* Ethernet address in the case of SLL or TLL options */
};
-BUILD_ASSERT_DECL(ND_OPT_LEN == sizeof(struct ovs_nd_opt));
+BUILD_ASSERT_DECL(ND_LLA_OPT_LEN == sizeof(struct ovs_nd_lla_opt));
/* Neighbor Discovery option: Prefix Information. */
#define ND_PREFIX_OPT_LEN 32
@@ -873,7 +872,7 @@ struct ovs_nd_msg {
struct icmp6_header icmph;
ovs_16aligned_be32 rso_flags;
union ovs_16aligned_in6_addr target;
- struct ovs_nd_opt options[0];
+ struct ovs_nd_lla_opt options[0];
};
BUILD_ASSERT_DECL(ND_MSG_LEN == sizeof(struct ovs_nd_msg));
--
2.7.4
More information about the dev
mailing list