[ovs-dev] [PATCH v2 3/8] ovn: extend expr symbols for ND

[Justin Pettit]

> On Sep 2, 2016, at 10:09 PM, Zongkai LI <zealokii at gmail.com> wrote:
> 
> This patch updates symbols in logical-fields for ND, such as "nd",
> "nd.target", "nd.sll", "nd.tll", to describe more clear about "icmp6.type"
> predicate.
> It adds new symbols:
> - "nd_rs" stands for Router Solicitation message,
> - "nd_ra" stands for Router Advertisement message,
> - "nd_rd" stands for Redirect message,
> 
> v1 -> v2
> rebased.
> ---

Add "signed-off-by:" and move version information.

> +    expr_symtab_add_predicate(symtab, "nd_rd",
> +              "icmp6.type == 137 && icmp6.code == 0 && ip.ttl == 255");

Are you using redirects anywhere?  They require a different message type, which I don't think has been introduced.  I'd just drop it if you're not introducing full support.

--Justin