[ovs-dev] [PATCH] ovn-controller: Fix memory leak in recv_S_TLV_TABLE_REQUESTED().

Ben Pfaff blp at ovn.org
Fri Sep 9 04:14:17 UTC 2016


On Thu, Sep 08, 2016 at 02:47:45PM -0700, Guru Shetty wrote:
> On 1 September 2016 at 10:02, Ben Pfaff <blp at ovn.org> wrote:
> 
> > Nothing freed 'reply'.  This fixes the problem.
> >
> > Most of this patch is moving coding around.  The essential change is that
> > breaking the code that works with 'reply' out into a separate function
> > makes it possible to catch all paths out of the function so that 'reply'
> > can be freed in one place.
> >
> > Reported-by: Ryan Moats <rmoats at us.ibm.com>
> > Signed-off-by: Ben Pfaff <blp at ovn.org>
> >
> 
> For me, this commit breaks multi-host networking. table 32 no longer has
> NXM_NX_TUN_METADATA related flows.
> 
> It would be nice if someone else can confirm.

Does reverting this commit from current master fix the problem?

Does anything get logged?

Does running ovn-controller under valgrind show up anything relevant?



More information about the dev mailing list