[ovs-dev] [PATCH v2 2/2] utilities: ovs-ctl: Handle start up errors

Aaron Conole aconole at redhat.com
Mon Sep 12 12:49:57 UTC 2016


Markos Chandras <mchandras at suse.de> writes:

> Make sure we take the return values into consideration so we can
> break early in case of failures. This makes the ovs-ctl helper more
> accurate in reporting the real status of its managing processes.
>
> Cc: Aaron Conole <aconole at redhat.com>
> Signed-off-by: Markos Chandras <mchandras at suse.de>

I like this change.  I haven't tested all the corner-cases with it, but
it's on my agenda - basically what happens during restart case when one
of the inner spawns causes failure.  I have tested some with it, and
like that it indicates status results properly.  I think you will need
to add something for the restart case, but that can be a follow on patch.

Acked-by: Aaron Conole <aconole at redhat.com>



More information about the dev mailing list