[ovs-dev] [PATCH 2/2] ovn-northd: Format logical flows a little better.

Gurucharan Shetty guru at ovn.org
Mon Sep 12 10:40:27 UTC 2016


This is a cosmetic fix.

Signed-off-by: Gurucharan Shetty <guru at ovn.org>
---
 ovn/northd/ovn-northd.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
index 648bd88..8b6f6a3 100644
--- a/ovn/northd/ovn-northd.c
+++ b/ovn/northd/ovn-northd.c
@@ -2559,9 +2559,9 @@ build_stateful(struct ovn_datapath *od, struct hmap *lflows)
             ds_put_format(&match, "ct.new && ip && ip4.dst == %s", ip_address);
             if (port) {
                 if (lb->protocol && !strcmp(lb->protocol, "udp")) {
-                    ds_put_format(&match, "&& udp && udp.dst == %d", port);
+                    ds_put_format(&match, " && udp && udp.dst == %d", port);
                 } else {
-                    ds_put_format(&match, "&& tcp && tcp.dst == %d", port);
+                    ds_put_format(&match, " && tcp && tcp.dst == %d", port);
                 }
                 ovn_lflow_add(lflows, od, S_SWITCH_IN_STATEFUL,
                               120, ds_cstr(&match), action);
@@ -3663,9 +3663,11 @@ build_lrouter_flows(struct hmap *datapaths, struct hmap *ports,
 
                 if (port) {
                     if (lb->protocol && !strcmp(lb->protocol, "udp")) {
-                        ds_put_format(&match, "&& udp && udp.dst == %d", port);
+                        ds_put_format(&match, " && udp && udp.dst == %d",
+                                      port);
                     } else {
-                        ds_put_format(&match, "&& tcp && tcp.dst == %d", port);
+                        ds_put_format(&match, " && tcp && tcp.dst == %d",
+                                      port);
                     }
                     ovn_lflow_add(lflows, od, S_ROUTER_IN_DNAT,
                                   120, ds_cstr(&match), ds_cstr(&actions));
-- 
1.9.1




More information about the dev mailing list