[ovs-dev] [PATCH v3 01/13] ofproto: Don't use connmgr after destruction.

Ben Pfaff blp at ovn.org
Tue Sep 13 17:56:33 UTC 2016


On Mon, Sep 12, 2016 at 01:52:31PM -0700, Jarno Rajahalme wrote:
> Set ofproto's connmgr pointer to NULL after the connmgr has been
> destructed, and check for NULL when sending a flow removed
> notification.
> 
> Verified by sending the flow removed message unconditionally and
> observing numerous core dumps in the test suite.
> 
> Found by inspection.
> 
> Fixes: f695ebfae5 ("ofproto: Postpone sending flow removed messages.")
> Signed-off-by: Jarno Rajahalme <jarno at ovn.org>
> ---
> v3: New patch for v3.

I'm worried a bit that the rules needed to access these structures
correctly are getting complicated.  Maybe there should be a high-level
overview somewhere.

Acked-by: Ben Pfaff <blp at ovn.org>



More information about the dev mailing list