[ovs-dev] [PATCH v3 07/13] ofproto-dpif-xlate: Expose xlate cache.

Ben Pfaff blp at ovn.org
Tue Sep 13 19:58:13 UTC 2016


On Mon, Sep 12, 2016 at 01:52:37PM -0700, Jarno Rajahalme wrote:
> Later patches will need to create xlate cache entries from different
> modules.  This patch refactors the xlate cache code in preparation
> without any functional changes, so that the changes are clearly
> visible in the following patches.
> 
> The definition of XC_ENTRY_FOR_EACH() iterator macro is changed so
> that it now does not take the xlate cache pointer to unify the usage
> accross all call sites.
> 
> Signed-off-by: Jarno Rajahalme <jarno at ovn.org>
> ---
> v3: Separated xlate cache to it's own module.

At the top of ofproto-dpif-xlate-cache.h, usually I alphabetize my
struct forward definitions.

Optionally we could get rid of the name for the 'u' member of struct
xc_entry, which would make references into the union a little more
convenient.

Thanks for working on this!

Acked-by: Ben Pfaff <blp at ovn.org>



More information about the dev mailing list