[ovs-dev] [PATCH v3 07/13] ofproto-dpif-xlate: Expose xlate cache.

Ben Pfaff blp at ovn.org
Wed Sep 14 00:16:01 UTC 2016


On Tue, Sep 13, 2016 at 03:21:49PM -0700, Jarno Rajahalme wrote:
> > On Sep 13, 2016, at 12:58 PM, Ben Pfaff <blp at ovn.org> wrote:
> > 
> > On Mon, Sep 12, 2016 at 01:52:37PM -0700, Jarno Rajahalme wrote:
> >> Later patches will need to create xlate cache entries from different
> >> modules.  This patch refactors the xlate cache code in preparation
> >> without any functional changes, so that the changes are clearly
> >> visible in the following patches.
> >> 
> >> The definition of XC_ENTRY_FOR_EACH() iterator macro is changed so
> >> that it now does not take the xlate cache pointer to unify the usage
> >> accross all call sites.
> >> 
> >> Signed-off-by: Jarno Rajahalme <jarno at ovn.org>
> >> ---
> >> v3: Separated xlate cache to it's own module.
> > 
> > At the top of ofproto-dpif-xlate-cache.h, usually I alphabetize my
> > struct forward definitions.
> 
> Done. Never used emacs sort-lines before :-)

Yeah, it's helpful once in a while, although "C-u M-| sort RET" has
pretty much the same effect.

> Did you skip the patch 06/13, or did I just not get the email? Either
> way, I’ll wait for that before pushing the rest of the series.

I think I read it and forgot to reply.  Done now.



More information about the dev mailing list