[ovs-dev] [PATCH] ovn-northd: Fix overlapping ARP/ND resolution logical flows.

[Ben Pfaff]

On Thu, Sep 22, 2016 at 11:28:11PM -0700, Justin Pettit wrote:
> 
> > On Sep 22, 2016, at 8:59 PM, Ben Pfaff <blp at ovn.org> wrote:
> > 
> > IPv4 and IPv6 packets have separate flows and should not overlap with a
> > catch-all flow that treats all packets like IPv4.  It's unpredictable what
> > flow actually gets chosen in this situation.
> > 
> > Found by inspection.
> > 
> > CC: Justin Pettit <jpettit at ovn.org>
> > Fixes: c34a87b6c570 ("ovn: Add support for IPv6 dynamic bindings.")
> > Signed-off-by: Ben Pfaff <blp at ovn.org>
> > ---
> > ovn/northd/ovn-northd.c | 2 --
> > 1 file changed, 2 deletions(-)
> > 
> > diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
> > index 2cbbb47..09ae732 100644
> > --- a/ovn/northd/ovn-northd.c
> > +++ b/ovn/northd/ovn-northd.c
> > @@ -4053,8 +4053,6 @@ build_lrouter_flows(struct hmap *datapaths, struct hmap *ports,
> >             continue;
> >         }
> > 
> > -        ovn_lflow_add(lflows, od, S_ROUTER_IN_ARP_RESOLVE, 0, "1",
> > -                      "get_arp(outport, reg0); next;");
> >         ovn_lflow_add(lflows, od, S_ROUTER_IN_ARP_RESOLVE, 0, "ip4",
> >                       "get_arp(outport, reg0); next;");
> 
> Good find.  Aren't you glad that my glacial-like conntrack patch delayed the release now?  (Don't answer that.)
> 
> Acked-by: Justin Pettit <jpettit at ovn.org>

Thanks, applied to master and branch-2.6.