[ovs-dev] [PATCH] netdev-dpdk: More correct log message on vhost_driver_unregister failure.

Daniele Di Proietto diproiettod at vmware.com
Fri Sep 23 20:58:11 UTC 2016


Makes sense to me, applied to master and branch-2.6

Thanks,

Daniele



On 23/09/2016 06:17, "Ilya Maximets" <i.maximets at samsung.com> wrote:

>Current error message incorrect for the client mode.
>
>Fixes: c1ff66ac80b5 ("netdev-dpdk: vHost client mode and reconnect")
>Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
>---
> lib/netdev-dpdk.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
>index ec43a08..cd7aaef 100644
>--- a/lib/netdev-dpdk.c
>+++ b/lib/netdev-dpdk.c
>@@ -1024,7 +1024,8 @@ netdev_dpdk_vhost_destruct(struct netdev *netdev)
>     ovs_mutex_unlock(&dpdk_mutex);
> 
>     if (dpdk_vhost_driver_unregister(dev, vhost_id)) {
>-        VLOG_ERR("Unable to remove vhost-user socket %s", vhost_id);
>+        VLOG_ERR("%s: Unable to unregister vhost driver for socket '%s'.\n",
>+                 netdev->name, vhost_id);
>     } else if (!(dev->vhost_driver_flags & RTE_VHOST_USER_CLIENT)) {
>         /* OVS server mode - remove this socket from list for deletion */
>         fatal_signal_remove_file_to_unlink(vhost_id);
>-- 
>2.7.4
>


More information about the dev mailing list