[ovs-dev] [PATCH v4] netdev-dpdk: Allow configurable queue sizes for 'dpdk' ports

Wed Sep 28 22:22:53 UTC 2016

Hi Ciara,

thanks for the patch, it looks good to me.

I only have a minor comment:

I'd like the requested values to depend only on the current database
state.  With the current patch when a value is invalid (not pow2 or bigger
than 4096) we keep the previous one.

Could you change dpdk_process_queue_size() to return a default value (which
can be passed as an argument) when the value from the database is absent or
not valid?

I guess dpdk_process_queue_size() could return this value directly, instead
of returning it through a pointer.

2016-09-22 7:25 GMT-07:00 Ilya Maximets <i.maximets at samsung.com>:

> I didn't test that, but it looks good to me.
>
> Acked-by: Ilya Maximets <i.maximets at samsung.com>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>