[ovs-dev] [PATCH V2] dpif-netlink: Fix log level for error message

Eric Garver e at erig.me
Tue Aug 1 22:49:12 UTC 2017


On Tue, Aug 01, 2017 at 01:56:44PM -0700, Joe Stringer wrote:
> On 1 August 2017 at 13:56, Joe Stringer <joe at ovn.org> wrote:
> > On 29 July 2017 at 21:58, Roi Dayan <roid at mellanox.com> wrote:
> >> Since it's an error but also will always occur in older kernels
> >> log the message with level warning instead of info.
> >>
> >> Signed-off-by: Roi Dayan <roid at mellanox.com>
> >> ---
> >
> > When I run this patch on a fedora system with kernel 4.8 and
> > out-of-tree modules, when running the "make check-kmod" tests, every
> > vxlan test now fails because the last step of the test checks the logs
> > for any log message with WARN or higher level, and this message shows
> > up. Looking at the other platforms affected, it seems like this will
> > always triggers on newer kernels in my test environment. Here's the
> > log:
> >
> > 2017-08-01T20:43:59.387Z|00053|dpif_netlink|WARN|Failed to create
> > at_vxlan0 with rtnetlink: Invalid argument
> >
> > I wonder if the new rtnetlink infrastructure is not always working for
> > VXLAN, and this error message is just highlighting that? Eric, could
> > this be related to VXLAN-GPE?
> 
> Correction: The non-GPE VXLAN tests fail in this case.

Yup, sorry. This broke with VXLAN-GPE, but we didn't notice because it
was falling back to the compat interface. A good example of why this log
needs to be higher. :)

I posted a fix.


More information about the dev mailing list