[ovs-dev] [PATCH v2] ovn: Fix the failing "2335: ovn -- ACL logging" test case

nusiddiq at redhat.com nusiddiq at redhat.com
Wed Aug 2 14:20:57 UTC 2017


From: Numan Siddique <nusiddiq at redhat.com>

The test case is failing mainly because of timing issue. Looking into the
ovn-controller.log it is evident that the last packet injected just before the
AT_CHECK, is still not processed by ovn-controller.

Fixes: d383eed59589 ("ovn: Add support for ACL logging.")
CC: Justin Pettit <jpettit at ovn.org>
Suggested-by: Lance Richardson <lrichard at redhat.com>
Signed-off-by: Numan Siddique <nusiddiq at redhat.com>
---
 tests/ovn.at | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/ovn.at b/tests/ovn.at
index cf356552f..40fa817f9 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -5840,6 +5840,8 @@ packet="inport==\"lp1\" && eth.src==$lp1_mac && eth.dst==$lp2_mac &&
         tcp && tcp.flags==2 && tcp.src==4367 && tcp.dst==87"
 as hv ovs-appctl -t ovn-controller inject-pkt "$packet"
 
+OVS_WAIT_UNTIL([ test 4 = $(grep -c 'acl_log' hv/ovn-controller.log) ])
+
 AT_CHECK([grep 'acl_log' hv/ovn-controller.log | sed 's/.*name=/name=/'], [0], [dnl
 name="drop-flow", verdict=drop, severity=alert: tcp,vlan_tci=0x0000,dl_src=f0:00:00:00:00:01,dl_dst=f0:00:00:00:00:02,nw_src=192.168.1.2,nw_dst=192.168.1.3,nw_tos=0,nw_ecn=0,nw_ttl=64,tp_src=4361,tp_dst=81,tcp_flags=syn
 name="allow-flow", verdict=allow, severity=info: tcp,vlan_tci=0x0000,dl_src=f0:00:00:00:00:01,dl_dst=f0:00:00:00:00:02,nw_src=192.168.1.2,nw_dst=192.168.1.3,nw_tos=0,nw_ecn=0,nw_ttl=64,tp_src=4363,tp_dst=83,tcp_flags=syn
-- 
2.13.3



More information about the dev mailing list