[ovs-dev] [PATCH] bridge: Avoid read of uninitialized data configuring Auto-Attach.

[Ben Pfaff]

This still needs a (trivial) review.

On Thu, Jul 06, 2017 at 02:33:42PM -0700, Ben Pfaff wrote:
> Reported-by: "qintao (F)" <qintao5 at huawei.com>
> Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2017-April/044309.html
> Signed-off-by: Ben Pfaff <blp at ovn.org>
> ---
>  vswitchd/bridge.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
> index 8336d7048dd1..f24fb9d72da9 100644
> --- a/vswitchd/bridge.c
> +++ b/vswitchd/bridge.c
> @@ -3895,7 +3895,7 @@ bridge_configure_aa(struct bridge *br)
>          union ovsdb_atom atom;
>  
>          atom.integer = m->isid;
> -        if (ovsdb_datum_find_key(mc, &atom, OVSDB_TYPE_UUID) == UINT_MAX) {
> +        if (ovsdb_datum_find_key(mc, &atom, OVSDB_TYPE_INTEGER) == UINT_MAX) {
>              VLOG_INFO("Deleting isid=%"PRIu32", vlan=%"PRIu16,
>                        m->isid, m->vlan);
>              bridge_aa_mapping_destroy(m);
> -- 
> 2.10.2
>