[ovs-dev] [PATCH 1/2] ofproto-dpif-xlate: Eliminate duplicate read of xcfgp.

Ben Pfaff blp at ovn.org
Wed Aug 2 22:09:04 UTC 2017


On Wed, Aug 02, 2017 at 02:10:31PM -0700, Andy Zhou wrote:
> On Wed, Aug 2, 2017 at 8:56 AM, Ben Pfaff <blp at ovn.org> wrote:
> > This inner 'xcfg' shadowed the outer one and could have read a different
> > value if 'xcfgp' was changing, so this is possibly a bug fix.
> >
> > Found by -Wshadow=local in GCC 7.
> >
> > Signed-off-by: Ben Pfaff <blp at ovn.org>
> Acked-by: Andy Zhou <azhou at ovn.org>

Thanks, I applied this to master and branch-2.7.  It didn't backport
trivially further than that.


More information about the dev mailing list