[ovs-dev] [PATCH 0/4] netdev-dpdk: Support multi-queue for ovs-dpdk QoS

赵占旭 zhaozhanxu at 163.com
Thu Aug 3 03:15:02 UTC 2017


I am very grateful to you for your advice. I made a v2 patchset series as below, I am sorry for sending it late, but I hope you can help me reviewing it and giving me more advice.



v2:
patch 0: https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/336184.html
patch 1: https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/336181.html
patch 2: https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/336183.html
patch 3: https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/336182.html
patch 4: https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/336185.html


Thanks








At 2017-07-23 00:09:10, "Stokes, Ian" <ian.stokes at intel.com> wrote:
>> Original command is as below:
>> 
>>     $ ovs-vsctl set port vhost-user0 qos=@newqos -- \
>>             --id=@newqos create qos type=egress-policer other-
>> config:cir=46000000 \
>>             other-config:cbs=2048`
>> 
>> Now it can support command as below:
>> 
>>     $ ovs-vsctl set port vhost-user0 qos=@newqos -- \
>>             --id=@newqos create qos type=egress-policer \
>>             other-config:cir=46000000 other-config:cbs=2048` \
>>             queues:123=@q123 queues:234=@q234 -- \
>>             --id=@q123 create queue other-config:cir=12800000 other-
>> config:cbs=2048 -- \
>>             --id=@q234 create queue other-config:cir=25600000 other-
>> config:cbs=2048`
>> 
>> Then, we can use OpenFlow to direct packet to queues:
>> 
>>     $ ovs-ofctl add-flow br0 in_port=5,actions=set_queue:123,normal
>>     $ ovs-ofctl add-flow br0 in_port=6,actions=set_queue:234,normal
>> 
>> Finally, we can use command `ovs-appctl -t ovs-vswitchd qos/show vhost-
>> user0` to show QoS queue information.
>> 
>> Signed-off-by: zhaozhanxu <zhaozhanxu at 163.com>
>> 
>> zhaozhanxu (4):
>>   Support multi-queue for ovs-dpdk QoS.
>>   Support multi-queue rate limit function for ovs-dpdk Qos.
>>   Support to show multi-queue qos info
>>   Modify QoS configure documents for ovs-dpdk
>> 
>>  Documentation/howto/dpdk.rst |  12 +-
>>  lib/netdev-dpdk.c            | 374
>> +++++++++++++++++++++++++++++++++++++++++--
>>  2 files changed, 374 insertions(+), 12 deletions(-)
>> 
>
>Hi zhaozhanxu,
>
>A few general comments that apply for all patches in this set:
>
>(1) You'll need to fix the commit messages for each to conform with what is expected for OVS patch submission. i.e. correct email message, summary and description of what the patch does.
>
>For more detail on what is expected you can consult the link below
>
>http://docs.openvswitch.org/en/latest/internals/contributing/submitting-patches/
>
>You can also check out other patches in the commit tree as a good guide for what's required.
>
>(2) Patches need to apply and compile independently of each other and should not break existing functionality. Patch 1 of this set breaks OVS compilation with the following 
>
>lib/netdev-dpdk.c:3095:31: error: field 'stats' has incomplete type
>     struct egress_queue_stats stats;
>
>and is later fixed by patch 3 of the set. This needs to be fixed in patch 1.
>
>(3) There are numerous OVS coding style infractions for each patch. The check patch utility located at /ovs/utilities/checkpatch.py can help you find these so that you can fix them. It should be run on each of your patches before submission.
>
>Note: Although this is a helpful tool it may not catch all coding style issues and it is useful to familiarize yourself with the coding style at https://github.com/openvswitch/ovs/blob/master/Documentation/internals/contributing/coding-style.rst
>
>I'm hoping to have a look in more detail a little later this week but if you can fix the above issues and send out a v2 patchset series I'd be happy to continue reviewing and testing.
>
>Thanks
>Ian
>
>> --
>> 2.7.4
>> 
>> 
>> _______________________________________________
>> dev mailing list
>> dev at openvswitch.org
>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev


More information about the dev mailing list