[ovs-dev] [PATCH] ovs-vsctl-bashcomp: Make compatible with busybox "awk".

Lance Richardson lrichard at redhat.com
Fri Aug 4 13:54:26 UTC 2017


> From: "Ben Pfaff" <blp at ovn.org>
> To: dev at openvswitch.org
> Cc: "Ben Pfaff" <blp at ovn.org>, "Stuart Cardall" <developer at it-offshore.co.uk>
> Sent: Friday, 14 July, 2017 12:42:54 AM
> Subject: [ovs-dev] [PATCH] ovs-vsctl-bashcomp: Make compatible with busybox	"awk".
> 
> It seems that awk in busybox doesn't think that an empty string is part of
> a larger string, but that GNU awk does.  This commit adds an extra test to
> make _ovs_vsctl_check_startswith_string work either way.
> 
> This allows the following tests to pass with busybox awk:
> 
> vsctl bashcomp unit tests
> 
>   7: vsctl-bashcomp - basic verification             ok
>   8: vsctl-bashcomp - argument completion            ok
> 
> Reported-by: Stuart Cardall <developer at it-offshore.co.uk>
> Signed-off-by: Ben Pfaff <blp at ovn.org>
> ---

Makes sense, verified that these test cases now pass in the Alpine
environment with busybox awk.

Acked-by: Lance Richardson <lrichard at redhat.com>


More information about the dev mailing list