[ovs-dev] [PATCH 1/2] ofproto-dpif-upcall: Fix action attr iteration.

Joe Stringer joe at ovn.org
Mon Aug 7 19:46:02 UTC 2017


On 3 August 2017 at 14:34, Ben Pfaff <blp at ovn.org> wrote:
> On Mon, Jul 31, 2017 at 04:54:21PM -0700, Joe Stringer wrote:
>> This calls is operating on messages generated by the datapath. If a
>> datapath implementation sends improperly formatted netlink attributes,
>> then it's possible for a revalidator thread to end up trapped in an
>> infinite loop iterating across the actions attributes. Rather than using
>> the UNSAFE variation of this iterator, use the regular version.
>>
>> Fixes: e672ff9b4d22 ("ofproto-dpif: Restore metadata and registers on recirculation.")
>> Signed-off-by: Joe Stringer <joe at ovn.org>
>
> Acked-by: Ben Pfaff <blp at ovn.org>

Thanks for the reviews, applied to master and branches 2.5-2.8.


More information about the dev mailing list