[ovs-dev] [PATCH 2/2] dpif: Fix clean up of dpif_ports on dpif_close().

Ben Pfaff blp at ovn.org
Tue Aug 8 00:00:10 UTC 2017


On Tue, Jun 27, 2017 at 11:13:10AM -0700, Joe Stringer wrote:
> Commit 32b77c316d9982("dpif: Save added ports in a port map.")
> introduced tracking of all dpif ports by taking a reference on each
> available netdev when the dpif is opened, but it failed to clear out and
> release references to these netdevs when the dpif is closed.
> 
> Balance the referencing of netdevs by introducing netdev_ports_flush()
> and clearing these during dpif_close().
> 
> Fixes: 32b77c316d9982("dpif: Save added ports in a port map.")
> Signed-off-by: Joe Stringer <joe at ovn.org>
> ---
> CC: Paul Blakey <paulb at mellanox.com>
> CC: Darrell Ball <dlu998 at gmail.com>

Hi Joe.  I'd like to take a look at this series but it no longer applies
because it uses a macro DPIF_HMAP_KEY that no longer exists.  Would you
mind rebasing and reposting?

Thanks,

Ben.


More information about the dev mailing list