[ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on init.

Darrell Ball dlu998 at gmail.com
Wed Aug 9 01:54:46 UTC 2017


Reset the DPDK HWOL checksum flags in dp_packet_init_.
The new HWOL bad checksum flag is uninitialized for non-dpdk ports and
this is noticed as test failures using netdev-dummy ports, when built with
the --with-dpdk flag set. Hence, in this case, packets may be marked as
having a bad checksum.

Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2017-August/045081.html
Fixes: 7451af618e0d ("dp-packet : Update DPDK rx checksum validation functions.")
CC: Sugesh Chandran <sugesh.chandran at intel.com>
Signed-off-by: Darrell Ball <dlu998 at gmail.com>
---

v3->v5: Update the commit message with more context.

v2->v3: Use existed API to reset both the DPDK HWOL flags.

v1->v2: Fix build failure for without --with-dpdk.

 lib/dp-packet.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/dp-packet.c b/lib/dp-packet.c
index 67aa406..4926993 100644
--- a/lib/dp-packet.c
+++ b/lib/dp-packet.c
@@ -31,6 +31,7 @@ dp_packet_init__(struct dp_packet *b, size_t allocated, enum dp_packet_source so
     dp_packet_reset_offsets(b);
     pkt_metadata_init(&b->md, 0);
     dp_packet_rss_invalidate(b);
+    reset_dp_packet_checksum_ol_flags(b);
     dp_packet_reset_cutlen(b);
     /* By default assume the packet type to be Ethernet. */
     b->packet_type = htonl(PT_ETH);
-- 
1.9.1



More information about the dev mailing list