[ovs-dev] [PATCHv2] ovn: Add support for ACL logging.

Miguel Angel Ajo Pelayo majopela at redhat.com
Wed Aug 9 09:02:48 UTC 2017


Nice addition :D

On Sat, Jul 29, 2017 at 2:01 AM, Justin Pettit <jpettit at ovn.org> wrote:

>
> > On Jul 28, 2017, at 4:57 PM, Ben Pfaff <blp at ovn.org> wrote:
> >
> > On Fri, Jul 28, 2017 at 03:48:38PM -0700, Justin Pettit wrote:
> >> Signed-off-by: Justin Pettit <jpettit at ovn.org>
> >> Acked-by: Han Zhou <zhouhan at gmail.com>
> >> ---
> >> v1->v2: Incorporate Ben and Han's feedback.
> >>        Improve output of "ovn-nbctl acl-list".
> >
> > Thank you!
> >
> > I'm appending a few final suggestions.  The only important one is the
> > one that moves the free() call, which I believe fixes a double-free on
> > the error path: the old name is freed but not set to NULL, which means
> > that ovnact_log_free() eventually frees it again.
>
> Good catches.  I added your changes and pushed to master.
>
> Thanks!
>
> --Justin
>
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>


More information about the dev mailing list