[ovs-dev] [PATCH] dp-packet: Use OVS_UNUSED to mark possibly unused parameters.

[Ben Pfaff]

Thanks, applied to master.

On Wed, Aug 09, 2017 at 06:09:12PM +0000, Darrell Ball wrote:
> Acked-by: Darrell Ball <dlu998 at gmail.com>
> 
> -----Original Message-----
> From: <ovs-dev-bounces at openvswitch.org> on behalf of Ben Pfaff <blp at ovn.org>
> Date: Wednesday, August 9, 2017 at 10:43 AM
> To: "dev at openvswitch.org" <dev at openvswitch.org>
> Cc: Ben Pfaff <blp at ovn.org>
> Subject: [ovs-dev] [PATCH] dp-packet: Use OVS_UNUSED to mark possibly unused	parameters.
> 
>     This is the way usually used in OVS.
>     
>     Signed-off-by: Ben Pfaff <blp at ovn.org>
>     ---
>      lib/dp-packet.h | 16 ++++++++--------
>      1 file changed, 8 insertions(+), 8 deletions(-)
>     
>     diff --git a/lib/dp-packet.h b/lib/dp-packet.h
>     index 9dbb611d95fb..8f52feeefa39 100644
>     --- a/lib/dp-packet.h
>     +++ b/lib/dp-packet.h
>     @@ -615,46 +615,46 @@ dp_packet_rss_invalidate(struct dp_packet *p)
>      }
>      
>      static inline bool
>     -dp_packet_ip_checksum_valid(struct dp_packet *p)
>     +dp_packet_ip_checksum_valid(struct dp_packet *p OVS_UNUSED)
>      {
>      #ifdef DPDK_NETDEV
>          return (p->mbuf.ol_flags & PKT_RX_IP_CKSUM_MASK) ==
>                  PKT_RX_IP_CKSUM_GOOD;
>      #else
>     -    return 0 && p;
>     +    return false;
>      #endif
>      }
>      
>      static inline bool
>     -dp_packet_ip_checksum_bad(struct dp_packet *p)
>     +dp_packet_ip_checksum_bad(struct dp_packet *p OVS_UNUSED)
>      {
>      #ifdef DPDK_NETDEV
>          return (p->mbuf.ol_flags & PKT_RX_IP_CKSUM_MASK) ==
>                  PKT_RX_IP_CKSUM_BAD;
>      #else
>     -    return 0 && p;
>     +    return false;
>      #endif
>      }
>      
>      static inline bool
>     -dp_packet_l4_checksum_valid(struct dp_packet *p)
>     +dp_packet_l4_checksum_valid(struct dp_packet *p OVS_UNUSED)
>      {
>      #ifdef DPDK_NETDEV
>          return (p->mbuf.ol_flags & PKT_RX_L4_CKSUM_MASK) ==
>                  PKT_RX_L4_CKSUM_GOOD;
>      #else
>     -    return 0 && p;
>     +    return false;
>      #endif
>      }
>      
>      static inline bool
>     -dp_packet_l4_checksum_bad(struct dp_packet *p)
>     +dp_packet_l4_checksum_bad(struct dp_packet *p OVS_UNUSED)
>      {
>      #ifdef DPDK_NETDEV
>          return (p->mbuf.ol_flags & PKT_RX_L4_CKSUM_MASK) ==
>                  PKT_RX_L4_CKSUM_BAD;
>      #else
>     -    return 0 && p;
>     +    return false;
>      #endif
>      }
>      
>     -- 
>     2.10.2
>     
>     _______________________________________________
>     dev mailing list
>     dev at openvswitch.org
>     https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=0RZDgi3QSeTa-OACTsQTtSjiq06eE5_d3BVy9x27k0I&s=JFbjrYsebeV29PPEYqsW3vTei-H5PjvFb2Z1MaYTZYY&e= 
>     
>