[ovs-dev] [patch_v4] dp-packet: Reset DPDK HWOL checksum flags on init.

Darrell Ball dball at vmware.com
Thu Aug 10 17:57:00 UTC 2017



-----Original Message-----
From: Aaron Conole <aconole at redhat.com>
Date: Thursday, August 10, 2017 at 10:13 AM
To: Darrell Ball <dball at vmware.com>
Cc: ovs dev <dev at openvswitch.org>
Subject: Re: [ovs-dev] [patch_v4] dp-packet: Reset DPDK HWOL checksum flags on init.

    Darrell Ball <dball at vmware.com> writes:
    
    > -----Original Message-----
    > From: Aaron Conole <aconole at redhat.com>
    > Date: Wednesday, August 9, 2017 at 12:51 PM
    > To: Darrell Ball <dball at vmware.com>
    > Cc: Joe Stringer <joe at ovn.org>, Darrell Ball <dlu998 at gmail.com>, ovs
    > dev <dev at openvswitch.org>
    > Subject: Re: [ovs-dev] [patch_v4] dp-packet: Reset DPDK HWOL checksum flags on init.
    >
    >     Darrell Ball <dball at vmware.com> writes:
    >     
    >     > Thanks Joe
    >     > I forgot to add your Tested-by to V5; I have been testing this myself;
    >     > but let me know if you would like it added – I can send a V6.
    >     
    >     It will automatically be added by patchwork.  It is sufficient to
    >     download (ex: https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.ozlabs.org_patch_799499_mbox&d=DwIFaQ&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=LK8s59ajLx5MbmH5Ng8SG1F1nAgKZJ_0JBs7phbl6C8&s=HRG5wrQrEXCl_AA8uAGbroVSvYGUIQjQkF8HrMRvNYI&e= )
    >     
    >     I usually use patchwork when working on a series - if I download it from
    >     patchwork, I can be confident that all the tags are applied properly, so
    >     I won't forget.  Plus, all the discussion happens there, so I can
    >     quickly browse it.
    >
    > Thanks Aaron
    > In this case, the Tested-by was applied to V4 and I sent a V5 which did not have the Tested-by.
    > The easiest solution would have been to ask Joe to respond to V5 – well, it is moot now anyways with V6 on the way.
    
    Yep, that happens.
    
    >     The full list is available at:
    >     https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.ozlabs.org_project_openvswitch_list_&d=DwIFaQ&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=LK8s59ajLx5MbmH5Ng8SG1F1nAgKZJ_0JBs7phbl6C8&s=rqaCq5Jr-Vy-cfQ_t5px-zGtdb55CQn9cIAZCC1PvfE&e= 
    >
    > Thanks, I am on this page most of the day (
    >     
    >     It would actually be cool to have a few more admins to troll patchwork
    >     and do things like ping for status (ex:
    >     https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.ozlabs.org_patch_719492_&d=DwIFaQ&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=LK8s59ajLx5MbmH5Ng8SG1F1nAgKZJ_0JBs7phbl6C8&s=y0RPF47IRVw8BujWHzB9oc7IUihgLuCenLfteZ2vUr4&e=  
    >
    > I don’t have any context on this patch.
    > Aaron, would you like to resurrect this patch with rebase ?; it is RHEL related.
    
    It doesn't need a rebase; it applies cleanly.  The version of patchwork
    running doesn't recognize my ack, so someone will have to add it
    manually (or omit it... doesn't matter too much, since Ben ack'd as
    well).
    
    But it would be cool to get it applied;  maybe even to get back as far
    as branch-2.7 (I think it was posted in time for 2.7 branch).


One thing is I don’t know if Daniele had a chance to test this, although it looks simple enough.
Did you get a chance to test it ? if so, maybe a tested-by  ?




    
    > is this still needed?  it
    >     does seem to mostly apply).  Then we could make sure we don't miss
    >     things.
    >     
    >     > Darrell
    >     >
    >     > -----Original Message-----
    >     > From: <ovs-dev-bounces at openvswitch.org> on behalf of Joe Stringer <joe at ovn.org>
    >     > Date: Tuesday, August 8, 2017 at 4:51 PM
    >     > To: Darrell Ball <dlu998 at gmail.com>
    >     > Cc: ovs dev <dev at openvswitch.org>
    >     > Subject: Re: [ovs-dev] [patch_v4] dp-packet: Reset DPDK HWOL checksum
    >     > flags on init.
    >     >
    >     >     On 8 August 2017 at 16:39, Darrell Ball <dlu998 at gmail.com> wrote:
    >     >     > Reset the DPDK HWOL checksum flags in dp_packet_init_.
    >     >     > The new HWOL bad checksum flag is uninitialized on non-dpdk ports and
    >     >     > this is noticed as test failures using netdev-dummy ports where the bad
    >     >     > checksum flag is checked.
    >     >     >
    >     >     > Fixes: 7451af618e0d ("dp-packet : Update DPDK rx checksum
    >     >     > validation functions.")
    >     >     > CC: Sugesh Chandran <sugesh.chandran at intel.com>
    >     >     > Signed-off-by: Darrell Ball <dlu998 at gmail.com>
    >     >     > ---
    >     >     
    >     >     Tested-by: Joe Stringer <joe at ovn.org>
    >     >     Tested-at: https://urldefense.proofpoint.com/v2/url?u=https-3A__travis-2Dci.org_joestringer_openvswitch_jobs_262464859&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=jXM8RI10bFYBt8zzW6xxX0MRb4YxJ_uCcOdGTE0sfJo&s=d664GG1tgARiN5uEJxebCnczlUnMDtHdWluYN0dRc5g&e= 
    >     >     
    >     >     I'll let those more familiar with this code provide the review.
    >     >     _______________________________________________
    >     >     dev mailing list
    >     >     dev at openvswitch.org
    >     >     https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=jXM8RI10bFYBt8zzW6xxX0MRb4YxJ_uCcOdGTE0sfJo&s=kCTOzFrO_3CdwW2mM_wcQZXMHDtzpo8cAuKlHSOcxTw&e= 
    >     >     
    >     >
    >     > _______________________________________________
    >     > dev mailing list
    >     > dev at openvswitch.org
    >     > https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwIFaQ&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=LK8s59ajLx5MbmH5Ng8SG1F1nAgKZJ_0JBs7phbl6C8&s=nnp778JNhzpZBELfmseffsohxJbAQgpKL0BLRS-vlmc&e= 
    >     
    >
    > _______________________________________________
    > dev mailing list
    > dev at openvswitch.org
    > https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwIFaQ&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=yugqtZ7cEvhndkLMeadOmLxKbGB-ACchJUijn0RMvgw&s=FCF3pi4o5SRXC7i_G7gTde-AR73L0CeKtclvdPylerk&e= 
    



More information about the dev mailing list