[ovs-dev] [PATCH] ovn-controller: Refactor function of consider_port_binding

Ben Pfaff blp at ovn.org
Thu Aug 10 18:53:49 UTC 2017


On Fri, Aug 04, 2017 at 10:31:14AM +0800, wang.qianyu at zte.com.cn wrote:
> The function of consider_port_binding is redundant. This patch split the 
> function to some sub-function by the port type.
> 
> Signed-off-by: wang qianyu <wang.qianyu at zte.com.cn>

Can you explain how it is redundant, and how this patch reduces it?

This patch makes two identical copies of the code for handling L3
gateway ports and patch ports, as patch_port_handle() and
l3gateway_port_handle(), so it's hard for me to see what redundancy it
eliminates.


More information about the dev mailing list