[ovs-dev] [PATCHv2] checkpatch: Enforce bracing around conditionals.

Aaron Conole aconole at redhat.com
Mon Aug 21 13:31:41 UTC 2017


Joe Stringer <joe at ovn.org> writes:

> The coding style states that BSD-style brace placement should be used,
> and even single statements should be enclosed. Add checks to checkpatch
> for this, particularly for 'else' statements.
>
> Signed-off-by: Joe Stringer <joe at ovn.org>
> ---

Acked-by: Aaron Conole <aconole at redhat.com>


Interestingly - if I do:

  $ find lib/ -name \*.c -exec ./utilities/checkpatch.py -f {} \; | \
         grep bracing | wc -l

before this patch: 92 instances of 'Inappropriate bracing'
after this patch: 102 instances of 'Inappropriate bracing'

-Aaron


More information about the dev mailing list