[ovs-dev] [PATCH 4/7] netdev-dpdk: implement flow put with rte flow

Yuanhan Liu yliu at fridaylinux.org
Wed Aug 30 02:33:28 UTC 2017


On Wed, Aug 30, 2017 at 02:02:23AM +0000, Darrell Ball wrote:
> 
>     >         +#define MAX_RTE_FLOW_ITEMS      100
>     >         +#define MAX_RTE_FLOW_ACTIONS    100
>     > 
>     > I guess these are temporary
>     
>     Yes, the hardcoded number is really hacky.
>     
>     > Do we need to do a rte query during initialization ?
>     
>     query on what?
> 
> [Darrell]
> I mean somehow the max hardware resources available at
> dev initialization time ? I realize this is non-trivial overall.

I see you point then. I don't think it's needed then. I'm also not
aware of there are such limitations existed (say, how many patterns
are supported).  I think we just add patterns as many as we can and
let the driver to figure out the rest. If the flow creation is failed,
we skip the hw offload, with an error message provided.
 
>     > static (inline) function maybe ?
>     
>     Indeed. I'm not a big fan of macro like this. Let me turn it to function
>     next time. I see no reason to make it inline (explicitly) though: it's
>     not in data path. Moreover, it's likely it will be inlined implicitly by
>     compiler.
> 
> [Darrell]
> I put ‘(inline)’ in parentheses because we would never specify it explicitly,
> since gcc would likely inline anyways. 

I see. Sorry for misunderstanding.

	--yliu


More information about the dev mailing list