[ovs-dev] [PATCH] fix ovsdb-server memory growth issues when ovs-vsctl cmd stucking.

[Ben Pfaff]

Great.  That patch is already on all relevant branches, so I guess we
are done here.  Thanks for figuring out the issue!

On Wed, Aug 30, 2017 at 03:49:43AM +0000, zengganghui wrote:
> We have found a patch (http://patchwork.ozlabs.org/patch/593753/) can resolve this problem.
> 
> BR.
> Zeng Ganghui
> Huawei Technologies Co., Ltd.
> 
> -----Original Message-----
> From: zengganghui 
> Sent: Monday, August 28, 2017 11:15 AM
> To: 'Ben Pfaff'
> Cc: dev at openvswitch.org
> Subject: RE: [PATCH] fix ovsdb-server memory growth issues when ovs-vsctl cmd stucking.
> 
> In our environment when applied this patch can solve this problem. For the root cause we are still analyzing, can you help us?
> Through our analysis, we suspect that when the ovs-vsctl cmd (ex: ovs-vsctl list interface) sticking, but unix socket link still exists. At this time if the ovsdb data updated, it will continue to send the updated data to ovs-vsctl. Resulting in continuous allocate rpc, but these rpcs cannot be released.
> 
> BR.
> Zeng Ganghui
> Huawei Technologies Co., Ltd.
> 
> -----Original Message-----
> From: Ben Pfaff [mailto:blp at ovn.org] 
> Sent: Sunday, August 27, 2017 6:33 AM
> To: zengganghui
> Cc: dev at openvswitch.org
> Subject: Re: [PATCH] fix ovsdb-server memory growth issues when ovs-vsctl cmd stucking.
> 
> On Sat, Aug 26, 2017 at 07:44:53PM +0800, ZengGanghui wrote:
> > When rpc sends message failed with return EAGIN, it will try to send again unlimitly.
> > Finally, the memory of ovsdb-server will grow infinitly.
> > 
> > Signed-off-by: ZengGanghui <zengganghui at huawei.com>
> 
> This patch doesn't make sense to me.  A failed stream send should not use memory.  Can you explain the problem and why this solves it?